[Webkit-unassigned] [Bug 72227] [GTK] improve platformSetDefersLoading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72227


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115169|review?                     |review-
               Flag|                            |




--- Comment #10 from Martin Robinson <mrobinson at webkit.org>  2011-11-15 08:42:29 PST ---
(From update of attachment 115169)
View in context: https://bugs.webkit.org/attachment.cgi?id=115169&action=review

Looks good to me, except that I think you are leaking the asyncResult.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:750
> +    // We only need to take action here to UN-defer loading

Nit: Missing a period.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:759
>          return;

Is it actually possible for m_cancellable to be non-null and d->m_soupRequest to be null? If so it'd be good to leave a small comment here explaining when and if not, it'd be better to ASSERT(d->m_soupRequest) instead.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:763
> +        GAsyncResult* asyncResult = d->m_deferredResult.leakRef();

I think you actually need to call adoptGRef here because the naked assignment adds another reference and the pointer leaks. Sorry for the confusion.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.