[Webkit-unassigned] [Bug 61528] Implement maxWidth check for canvas fill/strokeText

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61528


Stephen White <senorblanco at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115032|review?                     |review+
               Flag|                            |




--- Comment #30 from Stephen White <senorblanco at chromium.org>  2011-11-15 08:12:10 PST ---
(From update of attachment 115032)
View in context: https://bugs.webkit.org/attachment.cgi?id=115032&action=review

Looks good.  Thanks for the test coverage!  r=me

> LayoutTests/ChangeLog:22
> +        * resources/Ahem.ttf: Added.

(There already look to be at least 5 copies of Ahem.ttf in the tree, but Philip tells me he has a followup patch to consolidate all the copies).

> LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.negative.html:60
> +}, 50);

Hmm.  This timeout looks like it could introduce flakiness on a heavily-loaded machine (which our layout test bots tend to be).  Unfortunately, I don't know of a way to an onload for @fontface, so I don't have any bright ideas here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.