[Webkit-unassigned] [Bug 72294] Add contains() test to Region

Tue Nov 15 07:35:19 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=72294

--- Comment #18 from Dana Jansens <danakj at chromium.org>  2011-11-15 07:35:19 PST ---
(In reply to comment #17)
> (In reply to comment #12)
> > 1) I don't see the ability to do this operator== comparison at the moment.
> > 2) While I can implement the current contains() as operator==(), it will be slower than just doing a single walk (at least two, with possible mallocs/frees).  3) The operator==() method will be /more/ complex than the current contains() code.  It has to do a symmetric comparison rather than just testing one covering the other.
> > 
> 
> If two regions are equal, they will have exactly the same segments and spans, so checking for equality is as simple as a memcmp. If you can find a case where this isn't true, please file a separate bug about that.

We've been coming at this with different assumptions, mine being that the resulting intersecting region would not always have a single rect as its output if contains() was true.  It seems however that it does, so doing a simple operator== test should be feasable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.