[Webkit-unassigned] [Bug 72016] [Chromium] [WebSocket] export WebSocketChannel interface for plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72016





--- Comment #8 from Yuta Kitamura <yutak at chromium.org>  2011-11-15 05:44:20 PST ---
(From update of attachment 114904)
View in context: https://bugs.webkit.org/attachment.cgi?id=114904&action=review

>>> Source/WebCore/websockets/WebSocketChannel.h:72
>>> +    virtual bool send(const char* data, int length);
>> 
>> This overload might be confusing because it isn't clear whether this version sends a text message or a binary message; maybe we should rename the first overload to "sendText" and the other three to "sendBinary".
> 
> I see, but I'd like to split these refactoring into another change.
> Because that change will affect other WebSocket related files.
> It make the purpose of this change vague.

OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.