[Webkit-unassigned] [Bug 71050] [Microdata] Support for properties attribute.

Mon Nov 14 23:14:33 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=71050

--- Comment #7 from Arko Saha <nghq36 at motorola.com>  2011-11-14 23:14:33 PST ---
(In reply to comment #6)
> > m_itemProp, m_itemRef, m_itemType are just HTMLElement(HTMLElement.idl) attributes related to microdata. We set the value of these members from HTMLElement::parseMappedAttribute() when attribute changed accordingly. So I think there is no need to cache.
> >
> > Currently we don't cache properties collection i.e, m_properties. I thought of adding m_properties to RareData but the list of places where I should invalidate property collection cache was not clear to me so thought of handling it separately, may be in a seperate bug. I think we need to invalidate the cache when any attribute changes and when contents are appended/inserted/removed.
> > 
> > Please let me know your thoughts on the same.
> 
> IMHO, we should move them all to RareData.  Almost no HTMLElements will need these fields and the pointers are just taking up memory on all HTMLElements.

Ok. I will move them all to RareData and upload the patch. Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.