[Webkit-unassigned] [Bug 70407] [TexMap][QT] PageClientQt should skip redundant sync requests during Accelerated Composition.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70407





--- Comment #7 from Hwang <luxtella at company100.net>  2011-11-14 21:54:48 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > You're welcome.
> > 
> > I understood "shouldSync" is for makeForSync, but I did not understand yet why there is not something like this code.
> > if (shouldSync)
> >     doSomething();
> > 
> > Anyway, I am not sure whether the situation related to 600 sync as I mentioned is bug or not.
> > If it is bug, is it proper to add PageClientQGraphicsWidget's member variable like shouldSync in order to reduce redundant markForSync calls?
> 
> Hmmm... looking at it again some of that logic doesn't make sense, and might be leftovers from a previous iteration.
> But if we fix it let's do it right!
> Maybe the right fix should be to eliminate shouldSync, and to simply start the timer on markForSync?

line 302, syncTimer.startOneShot(0);
markForSync already simply starts the timer. What is mean?

I think I did not understand wholly what you said, so I hesitated to response more because it might be small problem or not problem.
You means it is better to resolve this bug because of INVALID?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.