[Webkit-unassigned] [Bug 70421] V8 bindings: event listener can be garbage collected, causing events loss

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70421


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115043|review?                     |review+
               Flag|                            |




--- Comment #15 from Adam Barth <abarth at webkit.org>  2011-11-14 17:06:35 PST ---
(From update of attachment 115043)
View in context: https://bugs.webkit.org/attachment.cgi?id=115043&action=review

I'm happy with the code change.  I'm less excited about the long test.  Below are some extremely minor style nits.  If we can make the test faster, great.  If not, we can live with it.

> Source/WebCore/bindings/v8/V8GCController.cpp:167
> +struct SpecialCasePrologueNodeHandler {

Normally we'd use "class" for traits classes.

> Source/WebCore/bindings/v8/V8GCController.cpp:174
> +template<typename T, typename S> class GCPrologueVisitor : public DOMWrapperMap<T>::Visitor {

Usually we have a line break before "class" in these template declarations.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.