[Webkit-unassigned] [Bug 72016] [Chromium] [WebSocket] export WebSocketChannel interface for plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72016





--- Comment #5 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-11-14 16:43:42 PST ---
(From update of attachment 114904)
View in context: https://bugs.webkit.org/attachment.cgi?id=114904&action=review

> Source/WebKit/chromium/public/WebWebSocketChannel.h:52
> +class WebWebSocketChannel {

ouch, the "WebWeb" prefix makes my head hurt! ;-)

since this is in the WebKit namespace, can we just call this one WebSocketChannel too?

>> Source/WebKit/chromium/public/WebWebSocketChannel.h:75
>> +    virtual void disconnect();
> 
> Why did you make these functions virtual?

I have the same question.

> Source/WebKit/chromium/public/WebWebSocketChannel.h:82
> +    WebCore::WebSocketChannelClientPrivate* m_client;

it is a bit atypical to store an additional pointer on classes like this.

perhaps it would be better to make WebKit::WebSocketChannel be a class with pure virtual functions (like WebFrame), and then provide a WebKit::WebSocketChannel::create() function that returns a WebKit::WebSocketChannel pointer.  You would then create WebSocketChannelImpl.{h,cpp}.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.