[Webkit-unassigned] [Bug 72324] DFG put_by_id transition optimizations test the wrong structures

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 14 16:36:27 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=72324


Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115053|review?                     |review+
               Flag|                            |




--- Comment #2 from Gavin Barraclough <barraclough at apple.com>  2011-11-14 16:36:27 PST ---
(From update of attachment 115053)
View in context: https://bugs.webkit.org/attachment.cgi?id=115053&action=review

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1825
> +                            if (previousStructure->storedPrototype().isCell())

I would prefer if the 'isCell' check check was a !isNull() check for consistency.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list