[Webkit-unassigned] [Bug 72208] [chromium] Fix scaleDelta zoom-out visibility rect bug

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72208





--- Comment #9 from Alexandre Elias <aelias at chromium.org>  2011-11-14 14:59:56 PST ---
(From update of attachment 115006)
View in context: https://bugs.webkit.org/attachment.cgi?id=115006&action=review

>> Source/WebCore/ChangeLog:30
>> +>2011-11-14  Pavel Feldman  <pfeldman at google.com>
> 
> something went awry here, there's a leading > on this line

Fixed

>> Source/WebCore/platform/graphics/chromium/LayerChromium.h:125
>> +    TransformationMatrix zoomAnimatorTransform() const { return TransformationMatrix(); }
> 
> hmmm, so main thread layers never have a non-identify zoomAnimatorTransform? How does the test hookup work then - that used to manipulate the zoomAnimatorTransform on CCLayerTreeHost directly.

It still manipulates CCLayerTreeHost directly, and then CCLayerTreeHostImpl pushes it to the CCLayerImpl.  This call is just to make the template happy.

>> Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h:123
>> +    const TransformationMatrix& zoomAnimatorTransform() const { return m_zoomAnimatorTransform; }
> 
> can you update CCLayerImplTest for this property?

Done

>> Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h:164
>> +    void setScaleDelta(float);
> 
> same here - please update CCLayerImplTest

Done

>> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:199
>> +    // LT = Tr[origin] * M[zoomAnimator] * S[scaleDelta] * Tr[origin2anchor]
> 
> the old comments grew the expression in the comment as the subsequent components were added, but this one seems to have the first three components in the comments before any modifications have taken place. I think this first comment should just be "LT = Tr[origin] * M[zoomAnimator]"

Fixed

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.