[Webkit-unassigned] [Bug 61528] Implement maxWidth check for canvas fill/strokeText

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61528


Philip Rogers <pdr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114559|0                           |1
        is obsolete|                            |
 Attachment #114559|review?, commit-queue?      |
               Flag|                            |
 Attachment #115032|                            |review?, commit-queue?
               Flag|                            |




--- Comment #29 from Philip Rogers <pdr at google.com>  2011-11-14 14:26:44 PST ---
Created an attachment (id=115032)
 --> (https://bugs.webkit.org/attachment.cgi?id=115032&action=review)
Fixes the canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html test

Replying to review Stephen White and attaching updated patch.

* A comment here might be helpful.  Do we really want to do a zero X scale in this case, or should we just skip drawing altogether if fontWidth is zero?
I added a comment about the composite operations (like copy) requiring this.

* Also, is this code path (gradient/pattern text) covered by the given tests?
Nice catch, they were not. I added the 2d.text.draw.fill.maxWidth.gradient test and made sure it fails on webkit but passes after this patch is applied.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.