[Webkit-unassigned] [Bug 71724] Optimize double border and outline rendering to avoid transparency layers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71724


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114203|review?                     |review-
               Flag|                            |




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-11-14 10:28:05 PST ---
(From update of attachment 114203)
View in context: https://bugs.webkit.org/attachment.cgi?id=114203&action=review

Do we have any pixel tests for double outlines? If not, we should.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1624
> +static void calculateThirds(const BorderEdge edges[], RoundedRect& outerThird, RoundedRect& innerThird)

Can we use this new method in an existing code?

> Source/WebCore/rendering/RenderObject.cpp:1158
> +                // We need certain integer rounding results
> +                if (outlineWidth % 3 == 2)
> +                    outerWidth += 1;
> +                if (outlineWidth % 3 == 1)
> +                    innerWidth += 1;
> +                LayoutRect innerThird = outer;

This is copied from BorderEdge::getDoubleBorderStripeWidths(). Please share that code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.