[Webkit-unassigned] [Bug 72258] [GTK] Implement download support in WebKit2

Mon Nov 14 10:17:29 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=72258

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114921|review?                     |review+
               Flag|                            |

--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-11-14 10:17:29 PST ---
(From update of attachment 114921)
View in context: https://bugs.webkit.org/attachment.cgi?id=114921&action=review

Looks good, but I'm not sure the changes in Source/WebKit/gtk/webkit/webkitdownload.cpp are necessary...

> Source/WebKit/gtk/webkit/webkitdownload.cpp:476
> +        webkitDownloadEmitError(download, downloadDestinationError(core(priv->networkResponse), error->message));

It It seems like this code is just using the ResourceError to carry the message and the error code to webkitDownloadEmitError. Why not just pass the error code and the message directly?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.