[Webkit-unassigned] [Bug 70421] V8 bindings: event listener can be garbage collected, causing events loss

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70421





--- Comment #6 from Eugene Nalimov <enal at google.com>  2011-11-14 08:22:22 PST ---
Will take care of suggestions, hopefully will send new patch later today.

No idea why test is listed as failing -- it is *not* in the list of failed tests, see output http://queues.webkit.org/results/10350618

Maybe it was skipped with lot of other tests after limit of failures was reached, but I am not sure.

Regarding perf: I don't expect one added indirect call to noticeably affect perf, especially because we are adding node to the map only once after it is created. Memory allocation and search in the map are much more expensive. And perf is exactly why I added new IsActiveNode() method to node instead of getting type descriptor and calling its toActive() method -- 1 indirect call instead of 2. 

Thanks,
Eugene

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.