[Webkit-unassigned] [Bug 72267] [GTK][WEBKIT2] Add enable-caret-browsing property to WebKitSettings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72267


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114945|0                           |1
        is obsolete|                            |
 Attachment #114945|review?                     |
               Flag|                            |
 Attachment #114949|                            |review?
               Flag|                            |




--- Comment #7 from Mario Sanchez Prada <msanchez at igalia.com>  2011-11-14 07:59:27 PST ---
Created an attachment (id=114949)
 --> (https://bugs.webkit.org/attachment.cgi?id=114949&action=review)
Patch proposal

(In reply to comment #6)
> [...]
> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:615
> > +    /**
> > +    * WebKitSettings:enable-caret-browsing:
> > +    *
> indentation is wrong here.

Fixed.

> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:616
> > +    * Whether to enable caret browsing mode.
> 
> hmm, maybe you could explain a bit what caret browsing means, or use "accessibility enhanced keyboard navigation" here too.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.