[Webkit-unassigned] [Bug 72227] [GTK] improve platformSetDefersLoading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72227





--- Comment #5 from Dan Winship <danw at gnome.org>  2011-11-14 06:10:37 PST ---
(In reply to comment #2)
> > +        No new tests. (OOPS!)
> 
> You'll need to remove the OOPS here for the cq to land this patch. You can just say something like, "No new tests. This is covered by existing tests."

Yeah, that was intentional:

> This patch also makes defersLoading work for non-http URIs, which
> didn't work before... I looked through the skipped tests list, but
> I couldn't find any that looked like they were being skipped because
> of that. Maybe we need a new one?


> It seems like there's nothing now to do in this method if defersLoading == true?

> This check existed only because calling soup_session_pause_message at the wrong time led to CRITICAL warnings. I'm pretty sure you can remove it competely now.

Ah, yeah. Cruft from earlier versions of the patch.

> > +        GRefPtr<GAsyncResult> asyncResult = d->m_deferredResult;
> > +        d->m_deferredResult = 0;
> 
> I think you can just do: RefPtr<GAsyncResult> asyncResult = adoptGRef(d->m_deferredResult.leakRef());

OK. But is that actually nicer? :)

Is http://www.webkit.org/coding/RefPtr.html out of date? Or does GRefPtr intentionally not work like RefPtr? I originally tried

    GRefPtr<GAsyncResult> asyncResult = d->m_deferredResult.release();

but GRefPtr doesn't have release() (and the docs on the RefPtr page say that leakRef() only exists on PassRefPtr)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.