[Webkit-unassigned] [Bug 72254] New: [Gtk 32 bit] Rounding error causes tests to fail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72254

           Summary: [Gtk 32 bit] Rounding error causes tests to fail
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: vanuan at gmail.com


Many SVG tests are failing on 32 bit Gtk build.

I've managed to have all rounding related tests pass by using these additional flags:


Index: GNUmakefile.am
===================================================================
--- GNUmakefile.am    (revision 99472)
+++ GNUmakefile.am    (working copy)
@@ -116,7 +116,8 @@
     -Wformat -Wformat-security -Wno-format-y2k -Wundef \
     -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings \
     -Wno-unused-parameter -Wno-parentheses \
-    -fno-exceptions -DENABLE_GLIB_SUPPORT=1
+    -fno-exceptions -DENABLE_GLIB_SUPPORT=1 \
+    -march=pentium4 -msse2 -mfpmath=sse


 global_cxxflags += \


The description of these flags and why they are needed is here: http://codesearch.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/build/common.gypi&q=file:build/common.gypi&exact_package=chromium&l=1718

Martin Robinson suggested that I should modify Tools/Scripts/webkitdirs.pm to ensure that this work-around only be applied when building via build-webkit. But I'm not sure how to do that.

How can we pass cppflags to autogen scripts from Tools/Scripts/webkitdirs.pm ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.