[Webkit-unassigned] [Bug 70421] V8 bindings: event listener can be garbage collected, causing events loss

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70421


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114561|review?                     |review+
               Flag|                            |




--- Comment #4 from Adam Barth <abarth at webkit.org>  2011-11-13 22:40:19 PST ---
(From update of attachment 114561)
View in context: https://bugs.webkit.org/attachment.cgi?id=114561&action=review

This is a nice solution.  Any idea why the test is failing?

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1700
> +    # A DOMObject that is an ActiveDOMObject and also a DOMNode should be treated as an DOMNode here.

Can you explain a bit more why?  I would naively expect ActiveDOMNode here.

> Source/WebCore/bindings/v8/V8DOMWrapper.cpp:95
> -    getDOMNodeMap().set(node, wrapper);
> +    if (node->isActiveNode())

I hope this doesn't slow us down on DOM benchmarks.  Please ping the perf sheriff when landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.