[Webkit-unassigned] [Bug 72128] CMake color output is missing when using build-webkit

Sun Nov 13 21:40:03 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=72128

--- Comment #9 from Ming Xie <mxie at rim.com>  2011-11-13 21:40:03 PST ---
(In reply to comment #8)
> Created an attachment (id=114877)
 --> (https://bugs.webkit.org/attachment.cgi?id=114877&action=review) [details]
> Patch

Updated patch with ChangeLog entry.

(In reply to comment #6)
> Only personal opinion: IMHO this hasn't to do anything with CMake. You only do some Regexp on the output. The original CMake colors depend on the real target type. IMHO the correct way to do this is a "--color" switch in the cake --build command. But it's harder to do there. ;-)
> If you still want to do it this way I'd prefer to change the name of the parameter to "--color" only, since it's not CMake related and can be implemented for the other build systems too.

There is already an option(--[no]-color) in filter-build-webkit script. Therefore, I can take out my --useCMakeColor option if you guys believe this is ok.

Thanks for the warm welcome btw. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.