[Webkit-unassigned] [Bug 72000] [CMAKE] Add the UseV8.cmake to WebCore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72000


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114827|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #17 from Daniel Bates <dbates at webkit.org>  2011-11-12 09:10:25 PST ---
(From update of attachment 114827)
View in context: https://bugs.webkit.org/attachment.cgi?id=114827&action=review

This looks sane to me. I have some minor nits.

> Source/WebCore/UseV8.cmake:15
> +LIST(APPEND WebCore_SOURCES

Please sort the entires in this list so that they appear in sorted order as produced by the Unix sort command.

> Source/WebCore/UseV8.cmake:167
> +LIST(APPEND WebCore_SOURCES
> +    ${JAVASCRIPTCORE_DIR}/yarr/YarrPattern.cpp
> +    ${JAVASCRIPTCORE_DIR}/yarr/YarrInterpreter.cpp
> +    ${JAVASCRIPTCORE_DIR}/yarr/YarrJIT.cpp
> +    ${JAVASCRIPTCORE_DIR}/yarr/YarrSyntaxChecker.cpp

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.