[Webkit-unassigned] [Bug 72000] [CMAKE] Add the UseV8.cmake to WebCore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72000





--- Comment #13 from Patrick R. Gansterer <paroga at paroga.com>  2011-11-12 00:35:46 PST ---
(From update of attachment 114824)
View in context: https://bugs.webkit.org/attachment.cgi?id=114824&action=review

> Source/WebCore/UseV8.cmake:218
> +SET(FEATURE_DEFINES_JAVASCRIPT "LANGUAGE_JAVASCRIPT=1")
> +SET(FEATURE_DEFINES_JAVASCRIPT "${FEATURE_DEFINES_JAVASCRIPT} V8_BINDING=1")

Why not SET(FEATURE_DEFINES_JAVASCRIPT "LANGUAGE_JAVASCRIPT=1 V8_BINDING=1") ?

> Source/WebCore/UseV8.cmake:227
> +    DEPENDS ${WEBCORE_DIR}/inspector/xxd.pl ${WEBCORE_DIR}/bindings/v8/DebuggerScript.js

You don't need to add DebuggerScript.js, since it's already the MAIN_DEPENDENCY

> Source/WebCore/UseV8.cmake:244
> +    DEPENDS ${WEBCORE_DIR}/inspector/xxd.pl ${WEBCORE_DIR}/bindings/v8/custom/V8ArrayBufferViewCustomScript.js

no need for V8ArrayBufferViewCustomScript.js

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.