[Webkit-unassigned] [Bug 72128] CMake color output is missing when using build-webkit

Fri Nov 11 23:52:43 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=72128

--- Comment #6 from Patrick R. Gansterer <paroga at paroga.com>  2011-11-11 23:52:43 PST ---
(In reply to comment #5)
> This is my first patch to WebKit.org, please leave me comments if there is anything I should fix or improve.

So a warm welcome here at the webkit community! (Hoping to see many patches in the future :-) )

Every patch needs a ChangeLog entry. See http://www.webkit.org/coding/contributing.html for more infor. Tools/Scripts/webkit-patch is your friend.

> This patch adds a new subroutine processOutputWithCMakeColor() in filter-build-webkit.

Only personal opinion: IMHO this hasn't to do anything with CMake. You only do some Regexp on the output. The original CMake colors depend on the real target type. IMHO the correct way to do this is a "--color" switch in the cake --build command. But it's harder to do there. ;-)
If you still want to do it this way I'd prefer to change the name of the parameter to "--color" only, since it's not CMake related and can be implemented for the other build systems too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.