[Webkit-unassigned] [Bug 72000] [CMAKE] Add the UseV8.cmake to WebCore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72000





--- Comment #11 from Patrick R. Gansterer <paroga at paroga.com>  2011-11-11 23:36:09 PST ---
(From update of attachment 114821)
View in context: https://bugs.webkit.org/attachment.cgi?id=114821&action=review

> Source/WebCore/ChangeLog:6
> +        https://bugs.webkit.org/show_bug.cgi?id=XXXXX

Pleas add a VALID bug number! ;-)

> Source/WebCore/UseV8.cmake:220
> +    SET(FEATURE_DEFINES_JAVASCRIPT "${FEATURE_DEFINES_JAVASCRIPT} V8_BINDING=1")

why do you add the in the loop? if you really need to add it for every feature you can add it the the set statement in the line before.

> Source/WebCore/UseV8.cmake:228
> +ADD_CUSTOM_COMMAND(
> +    OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/DebuggerScriptSource.h
> +    MAIN_DEPENDENCY bindings/v8/DebuggerScript.js
> +    COMMAND ${PERL_EXECUTABLE} ${WEBCORE_DIR}/inspector/xxd.pl DebuggerScriptSource_js ${WEBCORE_DIR}/bindings/v8/DebuggerScript.js ${DERIVED_SOURCES_WEBCORE_DIR}/DebuggerScriptSource.h
> +    VERBATIM)

you need to add DEPENDS ${WEBCORE_DIR}/inspector/xxd.pl (and all file it maybe includes) if you want to regenerate the output when xxd.pl changes

> Source/WebCore/UseV8.cmake:244
> +ADD_CUSTOM_COMMAND(
> +    OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/V8ArrayBufferViewCustomScript.h
> +    MAIN_DEPENDENCY bindings/v8/custom/V8ArrayBufferViewCustomScript.js
> +    COMMAND ${PERL_EXECUTABLE} ${WEBCORE_DIR}/inspector/xxd.pl V8ArrayBufferViewCustomScript_js ${WEBCORE_DIR}/bindings/v8/custom/V8ArrayBufferViewCustomScript.js ${DERIVED_SOURCES_WEBCORE_DIR}/V8ArrayBufferViewCustomScript.h
> +    VERBATIM)

missing dependency to xxd.pl

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.