[Webkit-unassigned] [Bug 72000] [CMAKE] Add the UseV8.cmake to WebCore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72000





--- Comment #7 from Patrick R. Gansterer <paroga at paroga.com>  2011-11-11 22:25:38 PST ---
(In reply to comment #6)
> (In reply to comment #2)
> > (From update of attachment 114440 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=114440&action=review
> > 
> > > Source/WebCore/UseV8.cmake:229
> > > +SET(FEATURE_DEFINES_JAVASCRIPT "LANGUAGE_JAVASCRIPT=1")
> > > +SET(FEATURE_DEFINES_JAVASCRIPT "${FEATURE_DEFINES_JAVASCRIPT} V8_BINDING=1")
> > 
> > Why not have these in a single call?
> 
> I will replace these with belows 
> 
> +SET(FEATURE_DEFINES_JAVASCRIPT "LANGUAGE_JAVASCRIPT=1")
> +FOREACH (_feature ${FEATURE_DEFINES})
> +    SET(FEATURE_DEFINES_JAVASCRIPT "${FEATURE_DEFINES_JAVASCRIPT} ${_feature}")
> +    SET(FEATURE_DEFINES_JAVASCRIPT "${FEATURE_DEFINES_JAVASCRIPT} V8_BINDING=1")
> +ENDFOREACH ()

Why do you add V8_BINDING=1 not only once?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.