[Webkit-unassigned] [Bug 72188] Expose compositeAndReadback in WebLayerTreeView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72188


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114777|review?                     |review-
               Flag|                            |




--- Comment #4 from James Robinson <jamesr at chromium.org>  2011-11-11 15:34:08 PST ---
(From update of attachment 114777)
View in context: https://bugs.webkit.org/attachment.cgi?id=114777&action=review

> Source/WebKit/chromium/public/WebLayerTreeView.h:86
> +                                            int width,
> +                                            int height);

this should not line wrap and it should use a WebSize parameter instead of a pair of ints

can you document the ownership model and requirements of the pixels buffer, and what goes into them (pretty sure it's rgba values)

you also need to document the return value and what happens to *pixels when this function returns false

> Source/WebKit/chromium/src/WebLayerTreeView.cpp:93
> +        pixels, WebCore::IntRect(0, 0, width, height));

don't line wrap this either

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.