[Webkit-unassigned] [Bug 71352] [EFL] Port tiled backing store

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71352





--- Comment #14 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-11-11 15:09:24 PST ---
(From update of attachment 114005)
View in context: https://bugs.webkit.org/attachment.cgi?id=114005&action=review

> Source/WebKit/efl/ewk/ewk_private.h:165
> +void ewk_view_backing_store_invalidate(Evas_Object* o, const WebCore::IntRect& area);
> +void ewk_view_backing_store_adjuct_visible_rect(Evas_Object* o);
> +Eina_Bool ewk_view_setting_tiled_backing_store_enable_set(Evas_Object* o, Eina_Bool enable);

I think you can omit "o" as a parameter name, and the Eina_Bool can be a simple bool.

> Source/WebKit/efl/ewk/ewk_view.cpp:2288
> +#if USE(TILED_BACKING_STORE)

I think these #if checks should be moved to the function bodies, so the function symbols are always present.

> Source/WebKit/efl/ewk/ewk_view_single.cpp:56
> +    // use WebCore's backing store

Unneeded.

> Source/cmake/OptionsEfl.cmake:52
> +SET(WTF_USE_TILED_BACKING_STORE 1)
> +ADD_DEFINITIONS(-DWTF_USE_TILED_BACKING_STORE=1)

Thinking about this again, wouldn't it be better to make it an actual option? This way if one uses the build-webkit script the --tiled-backing-store can have an effect. It would also make the #if USE(TILED_BACKING_STORE) checks make sense, as right now they check for something that is always on.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.