[Webkit-unassigned] [Bug 70897] Use a simple page client/controller for user consent in getUserMedia()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70897


Adam Bergkvist <adam.bergkvist at ericsson.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114476|0                           |1
        is obsolete|                            |
 Attachment #114476|review?                     |
               Flag|                            |
 Attachment #114706|                            |review?, commit-queue?
               Flag|                            |




--- Comment #28 from Adam Bergkvist <adam.bergkvist at ericsson.com>  2011-11-11 08:44:01 PST ---
Created an attachment (id=114706)
 --> (https://bugs.webkit.org/attachment.cgi?id=114706&action=review)
Patch 4

(In reply to comment #26)
> (From update of attachment 114476 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114476&action=review
> 
> > Source/WebCore/mediastream/UserMediaController.cpp:82
> > +    ASSERT(m_requests.contains(request));
> 
> This function needs to be part of UserMediaController to use m_requests

Fixed.

> > Source/WebCore/mediastream/UserMediaController.cpp:87
> > +    ScriptExecutionContext* context = request->frame()->document();
> 
> Need to #include "Document.h" for this to compile.

Fixed.

> > Source/WebCore/mediastream/UserMediaRequest.cpp:58
> > +    , m_scriptExecutionContext(frame->document())
> 
> Need to #include "Document.h" for this to compile.

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.