[Webkit-unassigned] [Bug 72023] [GStreamer] GstCaps and GstPad RefPtr implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72023


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114697|review?                     |review+
               Flag|                            |




--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2011-11-11 08:27:46 PST ---
(From update of attachment 114697)
View in context: https://bugs.webkit.org/attachment.cgi?id=114697&action=review

Looks good, but please fix the minor issues below before landing. Thanks!

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1753
> +    pad.clear();
> +    pad = adoptGRef(gst_element_get_static_pad(m_webkitVideoSink, "sink"));

You shouldn't need to clear the pad first, you can just reassign it.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:234
> +    GRefPtr<GstPad> targetPad = gst_element_get_static_pad(GST_ELEMENT(priv->appsrc), "src");

Missing adoptGRef here?

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:733
> +            GRefPtr<GstCaps> caps = gst_caps_new_simple("application/x-icy", "metadata-interval", G_TYPE_INT, (gint) icyMetaInt, NULL);

Also need to use adoptRef here as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.