[Webkit-unassigned] [Bug 70496] Cannot select multiple options by mouse dragging in <select multiple="multiple" size="7"> list

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70496


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114447|review?                     |review-
               Flag|                            |




--- Comment #6 from Kent Tamura <tkent at chromium.org>  2011-11-11 01:30:36 PST ---
(From update of attachment 114447)
View in context: https://bugs.webkit.org/attachment.cgi?id=114447&action=review

> Source/WebCore/ChangeLog:12
> +        Test: fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html

Test coverage is not good.
We should test:
 - Dragging upward in a multiple listbox
 - Dragging in a multiple listbox with "addSelectionKey"
 - Dragging in a multiple listbox with "rangeSelectionKey"
 - Dragging in a non-multiple listbox
 - Dragging in a non-multiple listbox with "addSelectionKey"
 - Dragging in a non-multiple listbox with "rangeSelectionKey"

> Source/WebCore/html/HTMLSelectElement.cpp:1218
> +                updateSelectedState(listIndex, mouseEvent->ctrlKey(), mouseEvent->shiftKey());

I found passing ctrlKey() and shiftKey() is meaningless here because they are required only if m_multiple.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.