[Webkit-unassigned] [Bug 72089] JSString forgets to clear m_fibers when resolving ropes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72089





--- Comment #5 from Filip Pizlo <fpizlo at apple.com>  2011-11-10 22:11:06 PST ---
(In reply to comment #4)
> (From update of attachment 114626 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114626&action=review
> 
> > Source/JavaScriptCore/runtime/JSString.cpp:109
> > +        // Clearing here works only because there are no GC points in this method.
> 
> Might be good to merge this with the comment above, which ASSERTs that using a Vector is OK -- really, using a Vector is only OK because GC just won't happen.

Oh, heh, didn't even notice that comment.  I've gone for two comments, one to say that it's OK to put them into the Vector (because there are no GC points) and another to say that it's OK to clear m_fibers (because there are no GC points).  Figure that minimizes the chances of someone getting the wrong ideas.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.