[Webkit-unassigned] [Bug 68251] clipPath does not work on foreignObject

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68251





--- Comment #7 from Florin Malita <fmalita at google.com>  2011-11-10 16:14:32 PST ---
(From update of attachment 114155)
View in context: https://bugs.webkit.org/attachment.cgi?id=114155&action=review

Thanks for the review Dirk. I've added tests to exercise clipping, masking, filtering and opacity on FOs as suggested.

>> Source/WebCore/ChangeLog:6
>> +        Reviewed by NOBODY (OOPS!).
> 
> The change log needs to be more details. What have you done and why? This should be included in the change log.

Done.

>> Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp:62
>>          childPaintInfo.context->beginTransparencyLayer(opacity);
> 
> I think we do the opacity in SVGRenderSupport as well. Can you remove the calls here and after your code please? Also, can you add a test to verify the behavior please?

Done.

>> Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp:75
>>          childPaintInfo.context->endTransparencyLayer();
> 
> (needs to be removed as well)

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.