[Webkit-unassigned] [Bug 71579] Exposing getRect function in WebNode for chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71579





--- Comment #21 from Ilya Sherman <isherman at chromium.org>  2011-11-10 13:07:15 PST ---
(From update of attachment 114500)
View in context: https://bugs.webkit.org/attachment.cgi?id=114500&action=review

> Source/WebKit/chromium/ChangeLog:5
> +        This issue in chromium can be found at:

nit: Please capitalize "Chromium".

> Source/WebKit/chromium/ChangeLog:13
> +        (WebKit::WebNode::getRect):

nit: Please update this method name.

> Source/WebKit/chromium/public/WebElement.h:73
> +        WEBKIT_EXPORT WebRect boundsInWindowSpace();

nit: Can this method be marked const?

> Source/WebKit/chromium/src/WebElement.cpp:114
> +    return unwrap<Element>()->boundsInWindowSpace();

Oops, looks like this function just got renamed: [ http://trac.webkit.org/changeset/99778 ].

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.