[Webkit-unassigned] [Bug 71903] [chromium] Missing wait() in CCThreadProxy::setVisible

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 10 10:12:24 PST 2011


--- Comment #12 from Nat Duca <nduca at chromium.org>  2011-11-10 10:12:25 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 114502 [details] [details])
> > I'm going to add a new test case in CCLayerTreeHostTest, but it's not quite working as expected -- there may be further sneaky problems with setVisible().
> Aha, I see what's going on: setVisible(true) is asynchronous, so it only gets pushed to the CCScheduler at commit time, but commits are suppressed while we're invisible.
> Allowing commits while !visible works around this, but I'm not sure it's correct. I wonder if the core state machine should be checking visibility at all? Doing draws and commits while invisible isn't *wrong*, it's just inefficient. So maybe we should suppress those at a higher level, in the main thread.
> Anyway, I'll amend the patch and you can judge for yourself.

Wait, what's the expectation when setVisible(true)? Afaik, that should be a noop...

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list