[Webkit-unassigned] [Bug 71903] [chromium] Missing wait() in CCThreadProxy::setVisible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71903





--- Comment #5 from Iain Merrick <husky at google.com>  2011-11-10 08:03:00 PST ---
(From update of attachment 114262)
View in context: https://bugs.webkit.org/attachment.cgi?id=114262&action=review

>> Source/WebCore/platform/graphics/chromium/cc/CCCompletionEvent.h:56
>> +        ASSERT(!m_waited && (m_waited = true));
> 
> side-effects in an ASSERT() is pretty ugly - can you just do the assignment in an #ifndef NDEBUG block?  this reads like a bug, not something intentional

The #ifdef felt a bit noisy, but you're right, this is just icky. Will fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.