[Webkit-unassigned] [Bug 70642] [QT] new API to get selection bounds for visibleSelection
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 10 06:47:34 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=70642
--- Comment #7 from Antonio Gomes <tonikitoo at webkit.org> 2011-11-10 06:47:34 PST ---
(From update of attachment 114206)
View in context: https://bugs.webkit.org/attachment.cgi?id=114206&action=review
It must come with auto tests as well.
> Source/WebKit/qt/Api/qwebpage.cpp:4175
> +/*!
> + \fn bool QWebPage::selectionBounds(QRect& selectionStart, QRect& selectionEnd, QRect& boundingRect);
> +
Selection are per frame, so having it in WebPage, does not make sense to me.
Down the patch, you make use of FocusController::focusedOrMainFrame method, but a Frame can have text selection without being focused. Furthermore, two frames can have text selection simultaneously.
> Source/WebKit/qt/Api/qwebpage.cpp:4185
> +{
> + selectionStart = selectionEnd = boundingRect = QRect();
> + Frame* focusedFrame = d->page->focusController()->focusedFrame();
this is what I am talking about.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list