[Webkit-unassigned] [Bug 71538] [EFL] Remove EDJ based cursor.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71538





--- Comment #4 from Gustavo Lima Chaves <glima at profusion.mobi>  2011-11-10 05:44:29 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > Let me explain better/corrent my thougts.
> > 
> > The utility of edje cursors exists for applications willing to theme in a custom manner its cursors. I have just han an use case for that myself. By implementing the groups with names listed in CursorEfl.cpp, and ewk_view_theme_set()-ing the view with their implementation, one may have its own cursors for all those contexts.
> > 
> > What you say is that without ewk_view_theme_set(), the base theme won't have custom edje cursors and it will fallback to X ones. But that's just what we want, the default behavior to be making use of system cursors. If the user wishes to extend it, he/she HAS to provide it on its own theme extension. The cursor keys could be later documented on ewk_view_theme_set().
> > 
> 
> Yes, if someone want this feature, we should keep it.
> But, I can't understand why they want to change the webkit cursors instead of changing system cursors.
> 
> Can I know use case?

What webkit ends up doing itself IS calling the system cursor changing functions. It happens that  the EFL have API to set custom images/objects as the system cursor. Ewebkit will use that and expose this feature to its user via edje group lookups.

The use case is a browser app. which has custom cursors itself (think of embedded systems, intended to look not necessarily as the desktop). It will want to have the cursor changes made by webkit to match it's cursor theme.

> 
> > Finally, silencing webkit WRT cursor changes is not necessary, since we have these fallbacks.
> 
> This is just cleanup, but this cleanup can be a first step to move theme related code from WidgetEfl to RenderThemeEfl and ScrollbarThemeEfl where webkit really use theme.
> 
> Now, WidgetEfl store the theme information for Cursor and Scrollbar.
> IMO, changing cursor is unneeded feature and we should draw scrollbar instead of showing evas object(I want to discuss second one after checking more)

As I said, being able to theme these both things IS useful. They should stay. Whether the code where this magic takes place is misplaced is or not in ewebkit's tree is another matter.

> 
> So I really want to know whether this feature is really needed.
> I think that any other ports doesn't support this extension.

If they don't that's a limitation in comparison with ours. No big deal.

> If we really need this, I'll close the bug.

Please do :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.