[Webkit-unassigned] [Bug 72000] [CMAKE] Add the UseV8.cmake to WebCore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72000


Patrick R. Gansterer <paroga at paroga.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114440|review?, commit-queue?      |
               Flag|                            |




--- Comment #4 from Patrick R. Gansterer <paroga at paroga.com>  2011-11-10 04:05:07 PST ---
(From update of attachment 114440)
View in context: https://bugs.webkit.org/attachment.cgi?id=114440&action=review

> Source/WebCore/UseV8.cmake:19
> +    html/canvas/CanvasPixelArray.idl
> +
> +    storage/IDBVersionChangeEvent.idl
> +    storage/IDBVersionChangeRequest.idl

Are this IDL files part of V8? I don't think so. If you need them you should put them into the CMakeLists.txt

> Source/WebCore/UseV8.cmake:23
> +    bindings/generic/BindingSecurityBase.cpp

If it's generic it should go into the CMakeLists.txt

> Source/WebCore/UseV8.cmake:25
> +    bindings/ScriptControllerBase.cpp

already included in CMakeLists.txt

> Source/WebCore/UseV8.cmake:240
> +ADD_CUSTOM_COMMAND(
> +    OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/DebuggerScriptSource.h
> +    MAIN_DEPENDENCY bindings/v8/DebuggerScript.js
> +    COMMAND ${PERL_EXECUTABLE} ${WEBCORE_DIR}/inspector/xxd.pl DebuggerScriptSource_js ${WEBCORE_DIR}/bindings/v8/DebuggerScript.js ${DERIVED_SOURCES_WEBCORE_DIR}/DebuggerScriptSource.h
> +    VERBATIM)

Please add all other dependencies too, not only the MAIN_DEPENDENCY.

> Source/WebCore/UseV8.cmake:256
> +ADD_CUSTOM_COMMAND(
> +    OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/V8ArrayBufferViewCustomScript.h
> +    MAIN_DEPENDENCY bindings/v8/custom/V8ArrayBufferViewCustomScript.js
> +    COMMAND ${PERL_EXECUTABLE} ${WEBCORE_DIR}/inspector/xxd.pl V8ArrayBufferViewCustomScript_js ${WEBCORE_DIR}/bindings/v8/custom/V8ArrayBufferViewCustomScript.js ${DERIVED_SOURCES_WEBCORE_DIR}/V8ArrayBufferViewCustomScript.h
> +    VERBATIM)

Missing dependecies?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.