[Webkit-unassigned] [Bug 71350] Added TileCairo and TiledBackingStoreBackendCairo files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71350





--- Comment #8 from Joone Hur <joone.hur at collabora.co.uk>  2011-11-09 19:21:10 PST ---
(From update of attachment 113630)
View in context: https://bugs.webkit.org/attachment.cgi?id=113630&action=review

>> Source/WebCore/platform/graphics/cairo/TiledBackingStoreBackendCairo.cpp:46
>> +static const unsigned checkerColor2 = 0xffaaaaaa;
> 
> My issue with this is that it's really hard to tell just by looking at this lines what the colors are. I think they should be renamed to reflect what colors they are.

How about using checkerColorDarkGrey(0xff555555) and checkerColorLightGrey(0xffaaaaaa)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.