[Webkit-unassigned] [Bug 69703] HRTF Database consolidation

Wed Nov 9 16:30:14 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=69703

Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114344|review?                     |review+
               Flag|                            |

--- Comment #22 from Kenneth Russell <kbr at google.com>  2011-11-09 16:30:14 PST ---
(From update of attachment 114344)
View in context: https://bugs.webkit.org/attachment.cgi?id=114344&action=review

Based on Chris's review, r=me, but one comment. Also, it's concerning that none of the EWS bots handle this patch because of the wav file. I assume you'll handle this somehow. Perhaps you could regenerate the patch via Subversion and check it via EWS before committing it.

> Source/WebCore/platform/audio/HRTFElevation.cpp:90
> +#if PLATFORM(GTK)

Perhaps this and the PLATFORM(GTK) below could be hoisted to the top of the file, and define a file-local symbol like USE_CONCATENATED_IMPULSE_RESPONSES?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.