[Webkit-unassigned] [Bug 71962] New: Simplify the way that images are passed into a filter chain

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71962

           Summary: Simplify the way that images are passed into a filter
                    chain
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: SVG
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: simon.fraser at apple.com
                CC: zimmermann at kde.org, dino at apple.com,
                    timothy_horton at apple.com


Looking at the patch in bug 68472, I think the way that data gets into and out of filter chains could be improved. The code currently has to do:

m_filter->setSourceImageRect(size);
m_filter->setSourceImage(ImageBuffer::create(layoutSize));
GraphicsContext* sourceGraphicsContext = m_filter->sourceImage()->context();
// paint stuff

m_filter->effect()->apply();
p->drawImageBuffer(m_filter->effect()->asImageBuffer(), ...)


It seems like it would be much clearer as:

1. Make an ImageBuffer
2. Paint into the ImageBuffer
3. Hand the ImageBuffer to the filter.
4. Get the filtered result as an image buffer
5. Paint that image buffer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.