[Webkit-unassigned] [Bug 71920] [chromium] CCThreadProxy::finishAllRendering hangs if !visible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71920





--- Comment #10 from Nat Duca <nduca at chromium.org>  2011-11-09 14:22:18 PST ---
(From update of attachment 114311)
View in context: https://bugs.webkit.org/attachment.cgi?id=114311&action=review

s/forceRedraw/setNeedsForcedRedraw/ to be in keeping with naming in the class, and also not imply that it will happen immediately.

I'm fine waiting for vsync. As written, its cleaner this way and this is far from a fast path.

> Source/WebCore/platform/graphics/chromium/cc/CCScheduler.h:67
> +    // As setNeedsRedraw(), but ensures the draw will definitely happen even if we are not visible.

s/definitely //? :) Though, otoh, I like how emphatic it is! :)

> Source/WebKit/chromium/tests/CCSchedulerStateMachineTest.cpp:169
> +// As TestNextActionDrawsOnVSync, but with setVisible(false) and forceRedraw().

Fold this test into TestNextActionDrawsOnVsync but add an inner loop to each that considers both forced and non-forced draws? Less test-maintenance burden that way?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.