[Webkit-unassigned] [Bug 70642] [QT] new API to get selection bounds for visibleSelection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70642





--- Comment #5 from Srikumar B <srikumar.b at gmail.com>  2011-11-09 12:54:49 PST ---
Hi Simon,
Thanks for all your comments. I will upload a new patch with all the mentioned changes.

Regd the usecase, I am trying to draw selection markers at the start & end of selection for touch devices which does not have mouse pointer.
I believe this would be a better and generic approach to  get the selection details from FrameSelection.
please confirm your acceptance to add new API hence, i can upload the new patch with all your comments and Unit Test.

Thanks again


(In reply to comment #4)
> (From update of attachment 114206 [details])
> I'm going to say r-.
> 
>     1) The function is declared virtual even though it is not designed to be re-implemented.
>     2) Adding virtual functions breaks binary compatibility (for no reason here)
>     3) In Qt, out parameters are usually pointer types and the function signature starts with get.
>     4) There is no unit test for this feature.
> 
> Can you elaborate what you're trying to do in your application? Why do you have to retrieve three rectangles?
> 
> I think we need to understand your use-case better. But in general I'm hesitant in adding new API to the WebKit "1" part of QtWebKit. We would like to consider it "done" and avod adding new features.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.