[Webkit-unassigned] [Bug 63616] Add missing methods used by fast/notifications tests to LayoutTestController

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 9 12:47:56 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=63616





--- Comment #17 from Martin Robinson <mrobinson at webkit.org>  2011-11-09 12:47:56 PST ---
(From update of attachment 114323)
View in context: https://bugs.webkit.org/attachment.cgi?id=114323&action=review

This looks good to me with one small change. Other than that, I would r+ this patch.

> Tools/DumpRenderTree/LayoutTestController.h:146
> +    void simulateDesktopNotificationClick(JSStringRef);

You should include "title" here since JSStringRef is a generic type.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list