[Webkit-unassigned] [Bug 69703] HRTF Database consolidation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69703





--- Comment #18 from Chris Rogers <crogers at google.com>  2011-11-09 12:19:33 PST ---
(From update of attachment 114220)
View in context: https://bugs.webkit.org/attachment.cgi?id=114220&action=review

just comment nits at this point.

I'm going to ask Ken Russell to have a look at this for final review.

Thanks so much for this patch - I think the mac and chromium ports will eventually be interested in using this too!

> Source/WebCore/platform/audio/HRTFElevation.cpp:56
> +// Byte size of a single azimuth audio channel.

nit: the comment should really read:

// Number of frames in an individual impulse response.

> Source/WebCore/platform/audio/HRTFElevation.cpp:59
> +// Sample-rate of the spatialization impulse responses.

Might want to be more specific with the comment, something like:

// Sample-rate of the spatialization impulse responses as stored in the resource file.
// The impulse responses may be resampled to a different sample-rate (depending on the audio hardware) when they are loaded.

> Source/WebCore/platform/audio/HRTFElevation.cpp:151
> +    // The concatenated impulse response is a bus containing the all

Extra "the"  -- should be "is a bus containing all"

> Source/WebCore/platform/audio/HRTFElevation.cpp:160
> +

It would be great to have a comment here like:

// Extract the individual impulse response from the concatenated responses and potentially
// sample-rate convert it to the desired (hardware) sample-rate.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.