[Webkit-unassigned] [Bug 71903] [chromium] Missing wait() in CCThreadProxy::setVisible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71903


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114262|review?                     |review-
               Flag|                            |




--- Comment #4 from James Robinson <jamesr at chromium.org>  2011-11-09 12:01:43 PST ---
(From update of attachment 114262)
View in context: https://bugs.webkit.org/attachment.cgi?id=114262&action=review

No chance of a unit test? We have some CCLayerTreeHostTests that bounce between threads already.

> Source/WebCore/platform/graphics/chromium/cc/CCCompletionEvent.h:56
> +        ASSERT(!m_waited && (m_waited = true));

side-effects in an ASSERT() is pretty ugly - can you just do the assignment in an #ifndef NDEBUG block?  this reads like a bug, not something intentional

> Source/WebCore/platform/graphics/chromium/cc/CCCompletionEvent.h:63
> +        ASSERT(!m_signalled && (m_signalled = true));

same here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.