[Webkit-unassigned] [Bug 70642] [QT] new API to get selection bounds for visibleSelection

Wed Nov 9 11:52:36 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=70642

Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114206|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #4 from Simon Hausmann <hausmann at webkit.org>  2011-11-09 11:52:36 PST ---
(From update of attachment 114206)
I'm going to say r-.

    1) The function is declared virtual even though it is not designed to be re-implemented.
    2) Adding virtual functions breaks binary compatibility (for no reason here)
    3) In Qt, out parameters are usually pointer types and the function signature starts with get.
    4) There is no unit test for this feature.

Can you elaborate what you're trying to do in your application? Why do you have to retrieve three rectangles?

I think we need to understand your use-case better. But in general I'm hesitant in adding new API to the WebKit "1" part of QtWebKit. We would like to consider it "done" and avod adding new features.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.