[Webkit-unassigned] [Bug 60931] crash after r86584 due to calling willRemoveWheelEventHandler too many times

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60931





--- Comment #9 from Julien Chaffraix <jchaffraix at webkit.org>  2011-11-09 10:34:45 PST ---
(From update of attachment 101882)
View in context: https://bugs.webkit.org/attachment.cgi?id=101882&action=review

> Source/WebCore/ChangeLog:7
> +

It's unfortunate that there is no test case. The bug refers to 3 ASSERT in Chromium's test_expectations.txt, have you checked that your patch solves them? If it does not solve them, it looks like this is not a fix for the right bug. You would need an explanation as to why there is no test in this case.

> Source/WebCore/dom/Document.cpp:1793
> +            view->detachScrollbars();

There are 2 other callers to detachCustomScrollbars, wouldn't they also need to be converted to avoid such a bug too?

> Source/WebCore/page/FrameView.cpp:313
> +void FrameView::detachScrollbars()

It would also be neat to change FrameView::~FrameView to use this method for consistency.

> Source/WebCore/page/FrameView.cpp:316
> +        return;

I wonder if this check is needed. In detachCustomScrollbars, it looks like a legacy as none of the following code requires a Frame.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.