[Webkit-unassigned] [Bug 71920] [chromium] CCThreadProxy::finishAllRendering hangs if !visible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71920





--- Comment #4 from Iain Merrick <husky at google.com>  2011-11-09 09:47:25 PST ---
(From update of attachment 114286)
View in context: https://bugs.webkit.org/attachment.cgi?id=114286&action=review

>> Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:315
>> +        if (!m_schedulerOnImplThread->redrawPending() || !m_schedulerOnImplThread->visible()) {
> 
> Why null-check the completion event here if you just assigned to it?

Because setNeedsRedraw() will prod the state machine, and (I think) that can run the callback and clear out the completion event.

At first I thought the bug was just that lines 310 and 311 were in the wrong order.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.