[Webkit-unassigned] [Bug 71854] Access key should work on all elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 9 09:21:13 PST 2011


--- Comment #8 from Vineet Chaudhary (vineetc) <rgf748 at motorola.com>  2011-11-09 09:21:13 PST ---
(In reply to comment #7)
> (From update of attachment 114247 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114247&action=review
> > Source/WebCore/ChangeLog:10
> > +        As per specification http://dev.w3.org/html5/spec/Overview.html#elements-in-the-dom
> > +        says All HTML elements can have the accesskey content attribute set. Adding "accessKey"
> > +        attribute idl file as [Reflect].
> Do we need to remove accessKey from any other IDL files (i.e., because they're now redundant)?

I think we should keep them because "accessKey" attribute implementation is different for different elements.
Eg. For Input element(type=text) it sets the Focus while for anchor element it simulates click events.
Ref :  http://trac.webkit.org/browser/trunk/Source/WebCore/html/InputType.cpp#L445 and http://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLAnchorElement.cpp#L236

Or else should we move these implementations to HTMLElement::accessKeyAction() with if checks for each different element as you suggests.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list