[Webkit-unassigned] [Bug 71718] Apparent threading bug causes intermittent segfaults

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71718





--- Comment #5 from Alexey Proskuryakov <ap at webkit.org>  2011-11-09 08:57:35 PST ---
(From update of attachment 114287)
View in context: https://bugs.webkit.org/attachment.cgi?id=114287&action=review

The idea of the fix is correct.

Some time ago, we discussed having so many threading back-ends, and consensus was that ThreadingQt and other library specific implementations should be removed from WebKit. We can require either either POSIX threads or Win32 threads, and not waste time maintaining other back-ends.

>> Source/JavaScriptCore/wtf/qt/ThreadingQt.cpp:90
>> +    static Mutex* mutex = new Mutex();;
> 
> More than one command on the same line  [whitespace/newline] [4]

I suggest just copying this code from ThreadingPhreads:

    DEFINE_STATIC_LOCAL(Mutex, mutex, ());

>> Source/JavaScriptCore/wtf/qt/ThreadingQt.cpp:96
>> +    static HashMap<ThreadIdentifier, QThread*>* map = new HashMap<ThreadIdentifier, QThread*>();;
> 
> More than one command on the same line  [whitespace/newline] [4]

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.